linux-kernel - Re: [PATCH v2] scsi: scsi_devinfo: remove redundant 'found'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57435584-b04e-4de6-908c-018fe48ad0ac@acm.org>
Date: Mon, 23 Jun 2025 08:59:05 -0700
From: Bart Van Assche <bvanassche@....org>
To: mrigendrachaubey <mrigendra.chaubey@...il.com>,
 James.Bottomley@...senPartnership.com, martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: scsi_devinfo: remove redundant 'found'

On 6/21/25 10:57 PM, mrigendrachaubey wrote:
> Remove the unnecessary 'found' flag in scsi_devinfo_lookup_by_key().
> The loop can return the matching entry directly when found, and fall
> through to return ERR_PTR(-EINVAL) otherwise.
> 
> Signed-off-by: mrigendrachaubey <mrigendra.chaubey@...il.com>
> ---
>   drivers/scsi/scsi_devinfo.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index a348df895dca..e364829b6079 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -269,17 +269,12 @@ static struct {
>   static struct scsi_dev_info_list_table *scsi_devinfo_lookup_by_key(int key)
>   {
>   	struct scsi_dev_info_list_table *devinfo_table;
> -	int found = 0;
>   
>   	list_for_each_entry(devinfo_table, &scsi_dev_info_list, node)
> -		if (devinfo_table->key == key) {
> -			found = 1;
> -			break;
> -		}
> -	if (!found)
> -		return ERR_PTR(-EINVAL);
> +		if (devinfo_table->key == key)
> +			return devinfo_table;
>   
> -	return devinfo_table;
> +	return ERR_PTR(-EINVAL);
>   }

Reviewed-by: Bart Van Assche <bvanassche@....org>