linux-kernel - Re: [PATCH v10 02/14] unwind_user: Add frame pointer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f1c21e9-ba0f-4262-8f56-962e0a7d6877@oracle.com>
Date: Mon, 23 Jun 2025 09:31:17 -0700
From: Indu Bhagat <indu.bhagat@...cle.com>
To: Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        bpf@...r.kernel.org, x86@...nel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Poimboeuf <jpoimboe@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andrii Nakryiko <andrii@...nel.org>,
        "Jose E. Marchesi" <jemarch@....org>,
        Beau Belgrave <beaub@...ux.microsoft.com>,
        Jens Remus
 <jremus@...ux.ibm.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v10 02/14] unwind_user: Add frame pointer support

On 6/18/25 8:09 AM, Steven Rostedt wrote:
> On Wed, 18 Jun 2025 15:52:01 +0200
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
>>> +the_end:
>>> +	state->done = true;
>>>   	return -EINVAL;
>>>   }
>>
>> I'm thinking 'the_end' might be better named 'done' ?
> 
> I thought it was cute ;-) (BTW, I didn't name it).
> 
> But sure, I can update it to be something more common.
> 
>>
>> Also, CFA here is Call-Frame-Address and RA Return-Address ?
> 
> I believe so. Do you want me to add a comment?
> 

If a comment is added, Canonical Frame Address will be more appropriate.