linux-kernel - Re: [PATCH v1 0/3] x86/boot: Supply boot_param in rdi instead of rsi from startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250623162935.681-1-khaliidcaliy@gmail.com>
Date: Mon, 23 Jun 2025 16:29:34 +0000
From: Khalid Ali <khaliidcaliy@...il.com>
To: brgerst@...il.com,
	tglx@...utronix.de,
	mingo@...hat.com,
	bp@...en8.de,
	dave.hansen@...ux.intel.com,
	ubizjak@...il.com
Cc: x86@...nel.org,
	hpa@...or.com,
	linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] x86/boot: Supply boot_param in rdi instead of rsi from startup_64()

> This was never intended to conform to the C ABI, why is it necessary
> to change it?

Technically speaking, you are right, however that doesn't mean we can put something where
ever we like. We came from C code which is bootloader and we end up to C code, so we should 
comply the ABI here too.

> Also, you cannot break this up into three patches.  Every patch must
> be fully functional so that git bisect will work.

Thanks for the tip. I will do next time.