linux-kernel - Re: [linux-next-20250620] Fails to boot to IBM Power Server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa879d91-878d-41c4-bf7c-67bef4e376f1@linux.ibm.com>
Date: Mon, 23 Jun 2025 22:19:14 +0530
From: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: LKML <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>, linux-fsdevel@...r.kernel.org,
        riteshh@...ux.ibm.com
Subject: Re: [linux-next-20250620] Fails to boot to IBM Power Server


On 23/06/25 8:32 pm, Al Viro wrote:
> On Mon, Jun 23, 2025 at 08:22:28PM +0530, Venkat Rao Bagalkote wrote:
>> On 23/06/25 7:26 pm, Al Viro wrote:
>>> On Mon, Jun 23, 2025 at 07:20:03PM +0530, Venkat Rao Bagalkote wrote:
>>>
>>> [NULL pointer dereference somewhere in collect_paths()]
>>>
>>> Could you put objdump -d of the function in question somewhere?
>>> Or just fs/namespace.o from your build...
>>>
>> Attached is the namespace.o file.
> Huh...
>
> That looks like NULL first argument (path), which blows up on
>          struct mount *root = real_mount(path->mnt);
> just prior to grabbing namespace_sem...
>
> *blinks*
> <obscenities>
>
> Could you check if the delta below fixes it?
>
> diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
> index 68e042ae93c7..b0eae2a3c895 100644
> --- a/kernel/audit_tree.c
> +++ b/kernel/audit_tree.c
> @@ -832,7 +832,7 @@ int audit_add_tree_rule(struct audit_krule *rule)
>   	err = kern_path(tree->pathname, 0, &path);
>   	if (err)
>   		goto Err;
> -	paths = collect_paths(paths, array, 16);
> +	paths = collect_paths(&path, array, 16);
>   	path_put(&path);
>   	if (IS_ERR(paths)) {
>   		err = PTR_ERR(paths);


Tested the above patch and fixes the reported issue. Hence,


Tested-by: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>



Regards,

Venkat.