linux-kernel - Re: [PATCH v5 24/27] irqchip/gic-v5: Add GICv5 ITS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ms9ynusp.ffs@tglx>
Date: Mon, 23 Jun 2025 21:04:54 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: Marc Zyngier <maz@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Arnd Bergmann <arnd@...db.de>, Sascha Bischoff <sascha.bischoff@....com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, Timothy Hayes
 <timothy.hayes@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, "Liam R.
 Howlett" <Liam.Howlett@...cle.com>, Peter Maydell
 <peter.maydell@...aro.org>, Mark Rutland <mark.rutland@....com>, Jiri
 Slaby <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH v5 24/27] irqchip/gic-v5: Add GICv5 ITS support

On Mon, Jun 23 2025 at 11:26, Lorenzo Pieralisi wrote:
> On Fri, Jun 20, 2025 at 09:18:32PM +0200, Thomas Gleixner wrote:
>> Just add a MSI flag and set it in parent_ops::required_flags and extend
>
> I added that but it does not work (not if we use d->flags as below), it works
> if I add it as an
>
> IRQ_DOMAIN_FLAG_*
>
> and set it in irq_domain_info in the msi_create_parent_irq_domain()
> call in the GICv5 ITS driver when creating the domain.
>
>> the lib with
>> 
>>         struct fwnode_handle *fwh;
>> 
>>         fwh = d->flags & MAGIC ? fwnode_get_parent(fwspec->fwnode) : fwspec->fwnode;
>
> Here we are using the domain flags and I think that's what we want.
>
> If I go with parent_ops flag, I believe here we need to use the parent
> msi_domain_info::flags - I don't think that's what we want.
>
> It is a property of the IRQ domain so I think that adding an
>
> IRQ_DOMAIN_FLAG_FWNODE_PARENT
>
> is the best option.
>
> Please let me know.

Obviously. Doh :)