linux-kernel - Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84868edc-87fd-44ff-949f-60191f9bee35@linaro.org>
Date: Mon, 23 Jun 2025 08:21:01 +0200
From: neil.armstrong@...aro.org
To: Maulik Shah <maulik.shah@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support

On 23/06/2025 07:49, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
> 
> Signed-off-by: Maulik Shah <maulik.shah@....qualcomm.com>
> ---
>   drivers/soc/qcom/rpmh-rsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index cb82e887b51d4401edba713348eed9621622b73b..fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -1072,7 +1072,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
>   	drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT);
>   	drv->ver.minor >>= MINOR_VER_SHIFT;
>   
> -	if (drv->ver.major == 3)
> +	if (drv->ver.major >= 3)
>   		drv->regs = rpmh_rsc_reg_offset_ver_3_0;
>   	else
>   		drv->regs = rpmh_rsc_reg_offset_ver_2_7;
> 
> ---
> base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
> change-id: 20250623-rsc_v4-ec10a1aadbb8
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>