linux-kernel - Re: [PATCH v3 2/2] iio: temperature: add support for MCP998X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFj4EI5CEIIQ8adl@smile.fi.intel.com>
Date: Mon, 23 Jun 2025 09:45:36 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Victor.Duicu@...rochip.com,
	dlechner@...libre.com, nuno.sa@...log.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	robh@...nel.org, andy@...nel.org, krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org, Marius.Cristea@...rochip.com,
	conor+dt@...nel.org
Subject: Re: [PATCH v3 2/2] iio: temperature: add support for MCP998X

On Sat, Jun 21, 2025 at 06:19:46PM +0100, Jonathan Cameron wrote:
> On Thu, 19 Jun 2025 11:29:30 +0300
> Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> > On Thu, Jun 19, 2025 at 10:22 AM <Victor.Duicu@...rochip.com> wrote:
> > > On Sat, 2025-06-14 at 00:50 +0300, Andy Shevchenko wrote:  
> > > > On Fri, Jun 13, 2025 at 4:02 PM <victor.duicu@...rochip.com> wrote:  

...

> > > > > +MICROCHIP MCP9982 TEMPERATURE DRIVER
> > > > > +M:     Victor Duicu <victor.duicu@...rochip.com>
> > > > > +L:     linux-iio@...r.kernel.org
> > > > > +S:     Supported
> > > > > +F:
> > > > > Documentation/devicetree/bindings/iio/temperature/microchip,mcp9982
> > > > > .yaml
> > > > > +F:     drivers/iio/temperature/mcp9982.c  
> > > >
> > > > So, with the first patch only the dangling file will be present
> > > > without record in MAINTAINERS. Please, make sure that your DT schema
> > > > file is in MAINTAINERS.  
> > >
> > > Are you referring here to the file sysfs-bus-iio-temperature-mcp9982?
> > > This file was in v2 where there were a few custom attributes. In v3
> > > I removed them, so the driver currently doesn't have custom attributes.
> > > Should I had added it to the files in MAINTAINERS?  
> > 
> > You should have added the file to the MAINTAINERS in the same patch it
> > appears. Not in some arbitrary change afterwards.
> 
> Perhaps the confusion here is that Andy is talking about 2 lines above, not
> the immediate line above this feedback.  So the one with the dt-binding
> file.  If Victor was reading it as being about the .c file then
> this whole cross discussion makes more sense!

Yep, sorry for the confusion. My point is that the first patch in the series
added a file, it should start a MAINTAINERS at the same time.

-- 
With Best Regards,
Andy Shevchenko