[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aFj4kAXEhrR4Wbnz@kekkonen.localdomain>
Date: Mon, 23 Jun 2025 06:47:44 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Olivier Benjamin <olivier.benjamin@...tlin.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Jacopo Mondi <jacopo.mondi@...asonboard.com>,
Nicholas Roth <nicholas@...hemail.net>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>,
imx@...ts.linux.dev, ~diederik/pine64-discuss@...ts.sr.ht,
Dragan Simic <dsimic@...jaro.org>, Ondrej Jirman <megi@....cz>
Subject: Re: [PATCH v4 0/4] Describe the cameras in the PinePhone Pro dts
Hi Olivier,
On Fri, Jun 20, 2025 at 05:21:31PM +0200, Olivier Benjamin wrote:
> This series adds support for the Pine64 PinePhone Pro's rear and front
> cameras in Device Tree.
> This is based on some of Ondrej Jirman's patches hosted in his tree at
> https://codeberg.org/megi/linux, but I have also fully reviewed and
> re-written the code from the RK3399 datasheet, the PinePhone Pro
> schematic, and the IMX258-0AQH5 software reference manual.
>
> I have tested these changes on my PinePhone Pro and am able to take
> photos from both cameras using libcamera's cam.
>
> This series has raised a question about the proper label name for the
> front/user camera and rear/world camera for phones.
> This series is using "ucam" and "wcam", which is used in a few other
> Rockship DTBs:
> - arch/arm64/boot/dts/rockchip/px30-evb.dts
> - rk3399-gru-scarlet.dtsi
>
> Signed-off-by: Olivier Benjamin <olivier.benjamin@...tlin.com>
Thanks for the patches.
I've picked the first two in the set, presumably the rest will be merged
via another tree?
--
Regards,
Sakari Ailus
Powered by blists - more mailing lists