linux-kernel - Re: [PATCH v10] dma-engine: sun4i: Simplify error handling in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6500082-565a-4b00-ae27-4d943586e58b@prolan.hu>
Date: Mon, 23 Jun 2025 08:49:58 +0200
From: Csókás Bence <csokas.bence@...lan.hu>
To: Vinod Koul <vkoul@...nel.org>
CC: <dmaengine@...r.kernel.org>, Chen-Yu Tsai <wens@...nel.org>, "Jernej
 Skrabec" <jernej.skrabec@...il.com>, Chen-Yu Tsai <wens@...e.org>, "Julian
 Calaby" <julian.calaby@...il.com>, Samuel Holland <samuel@...lland.org>,
	<linux-kernel@...r.kernel.org>, <linux-sunxi@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v10] dma-engine: sun4i: Simplify error handling in probe()


On 2025. 06. 10. 9:53, Bence Csókás wrote:
> Clean up error handling by using devm functions and dev_err_probe(). This
> should make it easier to add new code, as we can eliminate the "goto
> ladder" in sun4i_dma_probe().
> 
> Suggested-by: Chen-Yu Tsai <wens@...nel.org>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>
> Acked-by: Chen-Yu Tsai <wens@...e.org>
> Reviewed-by: Julian Calaby <julian.calaby@...il.com>
> Signed-off-by: Bence Csókás <csokas.bence@...lan.hu>
> ---

Vinod, is there a problem with this patch? I'd love to hear your 
thoughts, because it has been practically unchanged since March, and 
only minor changes since the first submission last December. I can keep 
rebasing it ad nauseum every time you push to dma/next, but I think we 
both have a better use of our time. So, if you see anything that should 
prevent this from being merged, please tell me.

Thanks,
Bence