linux-kernel - Re: [PATCH] gpiolib-sysfs: fix use-after-free in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175066296706.10516.10782817854642788186.b4-ty@linaro.org>
Date: Mon, 23 Jun 2025 09:16:30 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: linux-gpio@...r.kernel.org,
	Antonio Quartulli <antonio@...delbit.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linus.walleij@...aro.org,
	brgl@...ev.pl,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib-sysfs: fix use-after-free in error path

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Mon, 23 Jun 2025 00:02:21 +0200, Antonio Quartulli wrote:
> When invoking device_create_with_groups() its return
> value is stored in `data->cdev_base`.
> However, in case of faiure, `data` is first
> freed and then derefernced in order to return
> `data->cdev_base`.
> 
> Fix the use-after-free by extracting the error
> code before free'ing `data`.
> 
> [...]

Thanks for the catch. I tweaked the commit message and added the Fixes: tag.
Applied, thanks!

[1/1] gpiolib-sysfs: fix use-after-free in error path
      https://git.kernel.org/brgl/linux/c/e6bb78570f7d531622ec572ef9ddbe6e66ff16ce

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>