linux-kernel - RE: [PATCH v1 0/2] Add BMP390 IIO driver, device tree bindings and support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DB9PR10MB64516B74B8FE3077E1CCE622C079A@DB9PR10MB6451.EURPRD10.PROD.OUTLOOK.COM>
Date: Mon, 23 Jun 2025 07:37:51 +0000
From: "Mereena Mathai Liquancin (MS/EHM4-BST)"
	<liquancin.mereenamathai@...bosch.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jic23@...nel.org" <jic23@...nel.org>, "dlechner@...libre.com"
	<dlechner@...libre.com>, "nuno.sa@...log.com" <nuno.sa@...log.com>,
	"andy@...nel.org" <andy@...nel.org>, "vassilisamir@...il.com"
	<vassilisamir@...il.com>, "marcelo.schmitt1@...il.com"
	<marcelo.schmitt1@...il.com>, "javier.carrasco.cruz@...il.com"
	<javier.carrasco.cruz@...il.com>, "ZHANG Xu (BST/ESA2)"
	<Xu.Zhang@...bosch.com>, "BIAN Maoting (BST/ESA2)"
	<Maoting.Bian@...bosch.com>
Subject: RE: [PATCH v1 0/2] Add BMP390 IIO driver, device tree bindings and
 support

Hi All,

I apologize for submitting such a large code patch earlier. I am currently reworking the driver to simplify the implementation and make the code easier to review and maintain.

Regarding the BMP2 and BMP3 devices, there are significant differences at the register level, so direct reuse of code is not feasible. However, I will carefully consider all the valuable feedback provided by the team to ensure the next version addresses the concerns raised.

I also plan to remove some unnecessary device tree nodes and redundant logic to streamline the driver further.

Thank you for taking the time to verify and review the patch. I appreciate the constructive comments and will incorporate them into the revised submission.

Best regards,

Liquancin Mereena Mathai

BST Projects (MS/EHM3-BST)
Bosch Global Software Technologies Private Limited
(CIN: U72400KA1997PTC023164) | KGISL Infrastructures Private Ltd - SEZ Keeranatham Village | Coimbatore | Tamil Nadu - 641035 | INDIA | www.bosch-softwaretechnologies.com
Liquancin.MereenaMathai@...bosch.com

Registered Office: Bosch Global Software Technologies Private Limited - (CIN: U72400KA1997PTC023164)
(Formerly known as Robert Bosch Engineering and Business Solutions Pvt. Ltd.)
123, Industrial Layout, Hosur Road, Koramangala, Bengaluru - 560095, India
Managing Director: Mr. Dattatri Salagame

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@...el.com> 
Sent: Monday, June 23, 2025 12:37 PM
To: Mereena Mathai Liquancin (MS/EHM4-BST) <liquancin.mereenamathai@...bosch.com>
Cc: linux-iio@...r.kernel.org; linux-kernel@...r.kernel.org; jic23@...nel.org; dlechner@...libre.com; nuno.sa@...log.com; andy@...nel.org; vassilisamir@...il.com; marcelo.schmitt1@...il.com; javier.carrasco.cruz@...il.com; ZHANG Xu (BST/ESA2) <Xu.Zhang@...bosch.com>; BIAN Maoting (BST/ESA2) <Maoting.Bian@...bosch.com>
Subject: Re: [PATCH v1 0/2] Add BMP390 IIO driver, device tree bindings and support

On Fri, Jun 20, 2025 at 10:24:53AM +0530, liquancin.mereenamathai@...bosch.com wrote:
> From: Liquancin Mereena Mathai <liquancin.mereenamathai@...bosch.com>
> 
> This patch series adds support for the Bosch BMP390 pressure sensor to 
> the Linux IIO subsystem. It includes the main driver implementation as 
> well as the necessary device tree bindings for integration on supported platforms.
> 
> Patch 1 adds the IIO driver for the BMP390 pressure sensor.
> Patch 2 introduces the device tree bindings documentation.

>  16 files changed, 7296 insertions(+)

You are kidding me.
Please, take your time to start with something really basic.
Also, can you explain how this driver is not duplicate of the (any of the) existing ones in IIO?

--
With Best Regards,
Andy Shevchenko