linux-kernel - Re: [PATCH v4 2/2] nfsd: Implement large extent array support in pNFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFkFHw0BcRO1i2bG@infradead.org>
Date: Mon, 23 Jun 2025 00:41:19 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Sergey Bashirov <sergeybashirov@...il.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	Christoph Hellwig <hch@...radead.org>,
	Jeff Layton <jlayton@...nel.org>, NeilBrown <neil@...wn.name>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Konstantin Evtushenko <koevtushenko@...dex.com>
Subject: Re: [PATCH v4 2/2] nfsd: Implement large extent array support in pNFS

On Sat, Jun 21, 2025 at 07:52:45PM +0300, Sergey Bashirov wrote:
> +	memcpy(&rqstp->rq_arg, &lcp->lc_up_layout, sizeof(struct xdr_buf));

Nit: using a struct assignment like:

	rqstp->rq_arg = lcp->lc_up_layout;

might be a tad bettet due to type safety here.

> +	memcpy(&rqstp->rq_arg, &lcp->lc_up_layout, sizeof(struct xdr_buf));

Same here.

Otherwise this looks good to me (but I'm not the best reviwer for XDR
code :)):

Reviewed-by: Christoph Hellwig <hch@....de>