linux-kernel - RE: [PATCH] edac: Use sysfs_emit_at() in dimmdev_location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134FEA0D8411C1D319F2C028979A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Mon, 23 Jun 2025 01:57:07 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Abhinav Ananthu <abhinav.ogl@...il.com>, "bp@...en8.de" <bp@...en8.de>
CC: "Luck, Tony" <tony.luck@...el.com>, "james.morse@....com"
	<james.morse@....com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"rric@...nel.org" <rric@...nel.org>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] edac: Use sysfs_emit_at() in dimmdev_location_show()

> From: Abhinav Ananthu <abhinav.ogl@...il.com>
> Sent: Friday, June 20, 2025 4:22 AM
> To: bp@...en8.de
> Cc: Luck, Tony <tony.luck@...el.com>; james.morse@....com;
> mchehab@...nel.org; rric@...nel.org; linux-edac@...r.kernel.org; linux-
> kernel@...r.kernel.org; Abhinav Ananthu <abhinav.ogl@...il.com>
> Subject: [PATCH] edac: Use sysfs_emit_at() in dimmdev_location_show()
> 
> Replace the use of scnprintf() with sysfs_emit_at() in
> dimmdev_location_show() to format the output into the sysfs buffer.
> 
> This change improves clarity and ensures proper bounds checking in line with
> the preferred sysfs_emit() API usage for sysfs 'show'
> functions. The PAGE_SIZE check is now handled internally by the helper.
> 
> No functional change intended.
> 
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@...il.com>

LGTM. Thanks.

   Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>