linux-kernel - Re: [PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y0tin8l0.wl-tiwai@suse.de>
Date: Mon, 23 Jun 2025 10:52:27 +0200
From: Takashi Iwai <tiwai@...e.de>
To: phasta@...nel.org,
	Philipp Stanner <phasta@...lbox.org>
Cc: Takashi Iwai <tiwai@...e.de>,
	Alok Tiwari <alok.a.tiwari@...cle.com>,
	perex@...ex.cz,
	tiwai@...e.com,
	andriy.shevchenko@...ux.intel.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

On Mon, 23 Jun 2025 10:02:30 +0200,
Philipp Stanner wrote:
> 
> On Sun, 2025-06-22 at 11:28 +0200, Takashi Iwai wrote:
> > On Sat, 21 Jun 2025 20:52:24 +0200,
> > Alok Tiwari wrote:
> > > 
> > > code mistakenly used a hardcoded index (codec[1]) instead of
> > > iterating, over the codec array using the loop variable i.
> > > Use codec[i] instead of codec[1] to match the loop iteration.
> > > 
> > > Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> > 
> > Applied now.  Thanks.
> 
> Shouldn't that have been a bug fix with
> 
> Fixes:
> and
> Cc: stable
> 
> ?

This change likely won't influence on the existing devices, and the
issue has been present from the very beginning of the driver code,
hence no regression.

The stuff in question is about the hardware of over 20 years ago, and
there has been no bug reports about this.  After all, all devices were
with at most two codecs, and this patch is for 3rd and 4th codecs.


thanks,

Takashi