linux-kernel - Re: [RFC PATCH] nfsd: convert the nfsd_users to atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E5A6E17D75867EA8+e74cfa32-ffd5-48b5-b5a4-b89b85f66866@chenxiaosong.com>
Date: Mon, 23 Jun 2025 16:52:05 +0800
From: ChenXiaoSong <chenxiaosong@...nxiaosong.com>
To: NeilBrown <neilb@...e.de>
Cc: chuck.lever@...cle.com, jlayton@...nel.org, okorniev@...hat.com,
 Dai.Ngo@...cle.com, tom@...pey.com, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org, huhai@...inos.cn,
 ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [RFC PATCH] nfsd: convert the nfsd_users to atomic_t

It seems this patch (or patchset) could resolve the issue.

Thanks for your reply.
ChenXiaoSong.

在 2025/6/20 19:55, NeilBrown 写道:
> The only possible cause that I can find for this crash is that the nfsd
> thread must have still been running when nfsd_shutdown_net() and then
> nfsd_shutdown_generic() were called resulting in the workqueue being
> destroyed.
> 
> The threads will all have been signalled with SIGKILL, but there was no
> mechanism to wait for the threads to complete.
> 
> This was changed in
> 
> Commit: 3409e4f1e8f2 ("NFSD: Make it possible to use svc_set_num_threads_sync")
> 
> Sync then threads were stopped synchronously so they were certainly all
> stopped before the workqueue was removed.
> 
> NeilBrown
>