linux-kernel - Re: [PATCH v3 1/3] dt-bindings: spi: Add binding document of Amlogic SPISG controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45514054-1bb0-450c-bff6-ffdf491417b1@kernel.org>
Date: Mon, 23 Jun 2025 11:15:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: xianwei.zhao@...ogic.com, Sunny Luo <sunny.luo@...ogic.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-amlogic@...ts.infradead.org, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: Add binding document of Amlogic
 SPISG controller

On 23/06/2025 10:53, Xianwei Zhao via B4 Relay wrote:

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> +properties:
> +  compatible:
> +    const: amlogic,a4-spisg
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 2

Nope, maxItems. Look at other bindings.

> +
> +  clock-names:
> +    items:
> +      - const: core
> +      - const: pclk
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    spi@...00 {
> +        compatible = "amlogic,a4-spisg";
> +        reg = <0x50000 0x38>;
> +        interrupts = <0 183 4>;

Use proper defines



Best regards,
Krzysztof