linux-kernel - Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFkbXFvOKeMALwBg@gmail.com>
Date: Mon, 23 Jun 2025 02:16:12 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
	ast@...nel.org
Subject: Re: [PATCH net-next RFC] selftests: net: add netpoll basic
 functionality test

On Sat, Jun 21, 2025 at 06:51:21AM -0700, Jakub Kicinski wrote:
> On Fri, 20 Jun 2025 01:39:43 -0700 Breno Leitao wrote:
> > > FWIW you can steal bpftrace integration from this series:
> > > https://lore.kernel.org/all/20250421222827.283737-22-kuba@kernel.org/  
> > 
> > Yes, that would be great. I think we can iterate until we hit the poll
> > path, otherwise we skip the test at timeout. Something as:
> > 
> > 	while (true):
> > 		send msg
> > 		if netpoll_poll_dev() was invoked:
> > 			ksft_exit
> > 		
> > 		if timeout:
> > 			raise KsftSkipEx
> > 	
> > As soon as your code lands, I will adapt the test to do so. Meanwhile,
> > I will send the v1 for the netpoll, and later we can iterate.
> > 
> > Thanks for working on this bfptrace helper. This will be useful on other
> > usecases as well.
> 
> Right, you're the second person I pointed that patch out to. Would be
> great if someone could steal that patch and make it a part of their
> series so that it gets merged 

I can do that. I was expecting your patches to be landed, and then
I would reuse it. I was not expecting to ship it as part of my patchset.


So, the selftest for netpoll is already in the mailing list[1], so, we
have two options, now:

  1) Steal your patch and make [1] depend on it.
  2) Merge the selftest [1] and, then, steal your patch by adding the
     bpftrace support in it.

What is your recommendation?

Link: https://lore.kernel.org/all/20250620-netpoll_test-v1-1-5068832f72fc@debian.org/ [1]

Thanks,
--breno