linux-kernel - Re: [PATCH] crypto: ccree - Don't use %pK through printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFkdjTsui7BZE5Kt@gondor.apana.org.au>
Date: Mon, 23 Jun 2025 17:25:33 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Gilad Ben-Yossef <gilad@...yossef.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccree - Don't use %pK through printk

On Wed, Jun 18, 2025 at 09:10:18AM +0200, Thomas Weißschuh wrote:
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
> the regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk(). They can still unintentionally leak raw pointers or
> acquire sleeping locks in atomic contexts.
> 
> Switch to the regular pointer formatting which is safer and
> easier to reason about.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
>  drivers/crypto/ccree/cc_buffer_mgr.c | 54 ++++++++++++++++++------------------
>  drivers/crypto/ccree/cc_cipher.c     |  4 +--
>  drivers/crypto/ccree/cc_hash.c       | 30 ++++++++++----------
>  3 files changed, 44 insertions(+), 44 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt