linux-kernel - Re: [PATCH 1/2] thunderbolt: Fix redundant Bit masking of ADP_DP_CS_1_AUX_RX_HOPID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250623095531.GX2824380@black.fi.intel.com>
Date: Mon, 23 Jun 2025 12:55:31 +0300
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: andreas.noever@...il.com, michael.jamet@...el.com, westeri@...nel.org,
	YehezkelShB@...il.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] thunderbolt: Fix redundant Bit masking of
 ADP_DP_CS_1_AUX_RX_HOPID_MASK

On Sun, Jun 22, 2025 at 10:17:02AM -0700, Alok Tiwari wrote:
> The tb_dp_port_set_hops() function was incorrectly clearing
> ADP_DP_CS_1_AUX_RX_HOPID_MASK twice.
> According to the function's purpose, it should clear both TX and RX AUX
> hop ID fields.
> Replace the first instance with ADP_DP_CS_1_AUX_TX_HOPID_MASK to ensure
> proper configuration of both AUX directions.
> 
> Fixes: 98176380cbe5 ("thunderbolt: Convert DP adapter register names to follow the USB4 spec")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Applied to thunderbolt.git/fixes, thanks!