linux-kernel - Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <739eb2d2-3e2c-4ab7-a040-75edc6f1ece0@kernel.org>
Date: Mon, 23 Jun 2025 12:25:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Satya Priya Kakitapalli <quic_skakitap@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Ajit Pandey <quic_ajipan@...cinc.com>,
 Imran Shaik <quic_imrashai@...cinc.com>, Taniya Das <quic_tdas@...cinc.com>,
 Jagadeesh Kona <quic_jkona@...cinc.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller
 node

On 23/06/2025 12:01, Konrad Dybcio wrote:
> On 6/23/25 10:44 AM, Krzysztof Kozlowski wrote:
>> On 23/06/2025 10:14, Satya Priya Kakitapalli wrote:
>>> Add device node for video clock controller on Qualcomm
>>> SC8180X platform.
>>>
>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
>>> ---
>>> Add device node for video clock controller on Qualcomm
>>> SC8180X platform.
>>> ---
>>>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> @@ -10,6 +10,7 @@
>>>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>>>  #include <dt-bindings/clock/qcom,rpmh.h>
>>>  #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
>>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>>  #include <dt-bindings/interconnect/qcom,icc.h>
>>>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>>  #include <dt-bindings/interconnect/qcom,sc8180x.h>
>>> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>>>  			};
>>>  		};
>>>  
>>> +		videocc: clock-controller@...0000 {
>> Why are you adding the same multiple times? This was added A YEAR AGO,
>> so you clearly send us some complete outdated ancient tree!
> 
> It seems like you're confusing something, there is no videocc node in
> sc8180x.dtsi


Heh, I am... the line below:
	compatible = "qcom,sm8150-videocc";
confused me and I looked at wrong file.

Satya:
Still for obvious reasons: NAK. See writing bindings or internal guideline.

Best regards,
Krzysztof