linux-kernel - Re: bridge/microchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bebca7c-d206-42a9-a233-f68f2c4cb1f1@microchip.com>
Date: Mon, 23 Jun 2025 10:54:36 +0000
From: <Dharma.B@...rochip.com>
To: <laurent.pinchart@...asonboard.com>
CC: <asrivats@...hat.com>, <dri-devel@...ts.freedesktop.org>,
	<Manikandan.M@...rochip.com>, <neil.armstrong@...aro.org>,
	<rfoss@...nel.org>, <jonas@...boo.se>, <jernej.skrabec@...il.com>,
	<maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
	<tzimmermann@...e.de>, <airlied@...il.com>, <simona@...ll.ch>,
	<linux-kernel@...r.kernel.org>
Subject: Re: bridge/microchip_lvds panel usage

Hi Laurent,

On 18/06/25 2:25 pm, Laurent Pinchart wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Jun 18, 2025 at 03:50:11AM +0000, Dharma.B@...rochip.com wrote:
>> On 18/06/25 5:06 am, Laurent Pinchart wrote:
>>> On Tue, Jun 17, 2025 at 10:36:34AM -0500, Anusha Srivatsa wrote:
>>>> Hey folks,
>>>>
>>>> Can someone please explain why the driver looks for a panel here:
>>>> https://elixir.bootlin.com/linux/v6.14.11/source/drivers/gpu/drm/bridge/
>>>> microchip-lvds.c#L182 and doesnt use it or set it up anywhere?
>>>>
>>>> I bumped into this while working on converting of_drm_find_panel() callers and
>>>> the lvds->panel usage in this driver felt off. Am I missing something?
>>>
>>> That doesn't seem needed.
>>
>> Currently the LVDS controller driver is hardcoded to map LVDS lanes to
>> the JEIDA format.
>>
>> In order to support the other format "VESA", we need this to query the
>> panel driver and set the appropriate format accordingly.
>>
>> "drm_panel_get_modes(lvds->panel, connector)"
> 
> It would be nice if this could be done using the bridge API instead. An
> LVDS sink does not necessarily need to be a panel.

Here is the updated patch
https://lore.kernel.org/lkml/20250623-microchip-lvds-v2-1-8ecbabc6abc4@microchip.com/

I will send another patch to remove "lvds->panel" as it is unused.

Thanks.
> 
>> We'll be submitting the patch upstream shortly.
>>
>>> By the way, please use plain text when posting to kernel mailing lists.
> 
> --
> Regards,
> 
> Laurent Pinchart


-- 
With Best Regards,
Dharma B.