linux-kernel - Re: [RESEND PATCH v2] kallsyms: fix build without execinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DATW4DAU81FO.388H7H1WSUKAB@pwned.life>
Date: Mon, 23 Jun 2025 13:53:11 +0200
From: "Achill Gilgenast" <fossdd@...ed.life>
To: "Andrew Morton" <akpm@...ux-foundation.org>
Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Linus Torvalds"
 <torvalds@...ux-foundation.org>, "Shuah Khan" <skhan@...uxfoundation.org>,
 <linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <stable@...r.kernel.org>
Subject: Re: [RESEND PATCH v2] kallsyms: fix build without execinfo

On Sun Jun 22, 2025 at 8:36 PM CEST, Andrew Morton wrote:
> On Sun, 22 Jun 2025 03:45:49 +0200 Achill Gilgenast <fossdd@...ed.life> wrote:
>
>> Some libc's like musl libc don't provide execinfo.h since it's not part
>> of POSIX. In order to fix compilation on musl, only include execinfo.h
>> if available (HAVE_BACKTRACE_SUPPORT)
>> 
>> This was discovered with c104c16073b7 ("Kunit to check the longest symbol length")
>> which starts to include linux/kallsyms.h with Alpine Linux' configs.
>> 
>> ...
>>
>> --- a/tools/include/linux/kallsyms.h
>> +++ b/tools/include/linux/kallsyms.h
>> @@ -18,6 +18,7 @@ static inline const char *kallsyms_lookup(unsigned long addr,
>>  	return NULL;
>>  }
>>  
>> +#ifdef HAVE_BACKTRACE_SUPPORT
>>  #include <execinfo.h>
>>  #include <stdlib.h>
>>  static inline void print_ip_sym(const char *loglvl, unsigned long ip)
>
> I'm not seeing anything in there which needs execinfo.h.  Can we simply
> remove the inclusion?

No, since backtrace_symbols is provided by execinfo.h.