linux-kernel - Re: [PATCH] Documentation/sysctl: coredump: add %F for pidfd number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250623-anwesen-hierin-326b4aaf5fec@brauner>
Date: Mon, 23 Jun 2025 13:55:02 +0200
From: Christian Brauner <brauner@...nel.org>
To: Salvatore Bonaccorso <carnil@...ian.org>
Cc: Jonathan Corbet <corbet@....net>, 
	Luca Boccassi <luca.boccassi@...il.com>, Oleg Nesterov <oleg@...hat.com>, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/sysctl: coredump: add %F for pidfd number

On Thu, Jun 12, 2025 at 08:02:04AM +0200, Salvatore Bonaccorso wrote:
> In commit b5325b2a270f ("coredump: hand a pidfd to the usermode coredump
> helper") a new core_pattern specifier, %F, was added to provide a pidfs
> to the usermode helper process referring to the crashed process.
> 
> Update the documentation to include the new core_pattern specifier.
> 
> Link: https://github.com/systemd/systemd/pull/37125
> Link: https://lwn.net/Articles/1024160/
> Signed-off-by: Salvatore Bonaccorso <carnil@...ian.org>
> ---

Thanks!

Just throwing a random thought out there: It would be nice if we could
optionally create a connection between a source code path/file and the
documentation directory/file in Documentation. For example, coredump
stuff is documented in Documentation/admin-guide/sysctl/kernel.rst so
there could be a line to that effect in fs/coredump.c and it creates a
warning if that file is removed.

Maybe that's dumb but it certainly would help to not miss such updates
in the future.

Christian

>  Documentation/admin-guide/sysctl/kernel.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index dd49a89a62d3..f1b2ab219a08 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -177,6 +177,7 @@ core_pattern
>  	%E		executable path
>  	%c		maximum size of core file by resource limit RLIMIT_CORE
>  	%C		CPU the task ran on
> +	%F		pidfd number
>  	%<OTHER>	both are dropped
>  	========	==========================================
>  
> -- 
> 2.49.0
>