linux-kernel - Re: [PATCH net-next v6 1/9] netmem: introduce struct netmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFlGCam4_FnkGQYT@hyeyoo>
Date: Mon, 23 Jun 2025 21:18:17 +0900
From: Harry Yoo <harry.yoo@...cle.com>
To: Byungchul Park <byungchul@...com>
Cc: David Hildenbrand <david@...hat.com>, willy@...radead.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, kernel_team@...ynix.com, kuba@...nel.org,
        almasrymina@...gle.com, ilias.apalodimas@...aro.org, hawk@...nel.org,
        akpm@...ux-foundation.org, davem@...emloft.net,
        john.fastabend@...il.com, andrew+netdev@...n.ch,
        asml.silence@...il.com, toke@...hat.com, tariqt@...dia.com,
        edumazet@...gle.com, pabeni@...hat.com, saeedm@...dia.com,
        leon@...nel.org, ast@...nel.org, daniel@...earbox.net,
        lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
        rppt@...nel.org, surenb@...gle.com, mhocko@...e.com, horms@...nel.org,
        linux-rdma@...r.kernel.org, bpf@...r.kernel.org,
        vishal.moola@...il.com, hannes@...xchg.org, ziy@...dia.com,
        jackmanb@...gle.com
Subject: Re: [PATCH net-next v6 1/9] netmem: introduce struct netmem_desc
 mirroring struct page

On Mon, Jun 23, 2025 at 07:28:21PM +0900, Byungchul Park wrote:
> On Mon, Jun 23, 2025 at 11:32:16AM +0200, David Hildenbrand wrote:
> > On 20.06.25 06:12, Byungchul Park wrote:
> > > To simplify struct page, the page pool members of struct page should be
> > > moved to other, allowing these members to be removed from struct page.
> > > 
> > > Introduce a network memory descriptor to store the members, struct
> > > netmem_desc, and make it union'ed with the existing fields in struct
> > > net_iov, allowing to organize the fields of struct net_iov.
> > 
> > It would be great adding some result from the previous discussions in
> > here, such as that the layout of "struct net_iov" can be changed because
> > it is not a "struct page" overlay, what the next steps based on this
> 
> I think the network folks already know how to use and interpret their
> data struct, struct net_iov for sure.. but I will add the comment if it
> you think is needed.  Thanks for the comment.

I agree with David - it's not immediately obvious at first glance.
That was my feedback on the previous version as well :)

I think it'd be great to add that explanation, since this is where MM and
networking intersect.

> 	Byungchul
> 
> > patch are etc.
> > 
> > --
> > Cheers,
> > 
> > David / dhildenb

-- 
Cheers,
Harry / Hyeonggon