Message-Id: <20250623123054.472216-1-panchuang@vivo.com>
Date: Mon, 23 Jun 2025 20:30:33 +0800
From: Pan Chuang <panchuang@...o.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Zhang Rui <rui.zhang@...el.com>,
	Lukasz Luba <lukasz.luba@....com>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Markus Mayer <mmayer@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	zhanghongchen <zhanghongchen@...ngson.cn>,
	Yinbo Zhu <zhuyinbo@...ngson.cn>,
	Amit Kucheria <amitk@...nel.org>,
	Thara Gopinath <thara.gopinath@...il.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Vasily Khoruzhick <anarsoul@...il.com>,
	Yangtao Li <tiny.windzz@...il.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Nícolas F. R. A. Prado <nfraprado@...labora.com>,
	Julien Panis <jpanis@...libre.com>,
	Arnd Bergmann <arnd@...db.de>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Raphael Gallais-Pou <rgallaispou@...il.com>,
	Patrice Chotard <patrice.chotard@...s.st.com>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Cheng-Yang Chou <yphbchou0911@...il.com>,
	Costa Shulyupin <costa.shul@...hat.com>,
	Caleb Sander Mateos <csander@...estorage.com>,
	Yury Norov <yury.norov@...il.com>,
	linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-sunxi@...ts.linux.dev,
	linux-tegra@...r.kernel.org,
	linux-mediatek@...ts.infradead.org
Cc: Pan Chuang <panchuang@...o.com>
Subject: [PATCH v6 00/24] Convert to use devm_request*_irq_probe()

There are more than 700 calls to devm_request_threaded_irq method and
more than 1000 calls to devm_request_irq method. Most drivers only
request one interrupt resource, and these error messages are basically
the same. If error messages are printed everywhere, more than 2000 lines
of code can be saved by removing the msg in the driver.

And tglx point out that:

  If we actually look at the call sites of
  devm_request_threaded_irq() then the vast majority of them print more or
  less lousy error messages. A quick grep/sed/awk/sort/uniq revealed

     519 messages total (there are probably more)

     352 unique messages

     323 unique messages after lower casing

         Those 323 are mostly just variants of the same patterns with
         slight modifications in formatting and information provided.

     186 of these messages do not deliver any useful information,
         e.g. "no irq", "

     The most useful one of all is: "could request wakeup irq: %d"

  So there is certainly an argument to be made that this particular
  function should print a well formatted and informative error message.

  It's not a general allocator like kmalloc(). It's specialized and in the
  vast majority of cases failing to request the interrupt causes the
  device probe to fail. So having proper and consistent information why
  the device cannot be used _is_ useful.

So add devm_request_threaded_irq_probe() and devm_request_irq_probe(),
which ensure that all error handling branches print error information.
In this way, when this function fails, the upper-layer functions can
directly return an error code without missing debugging information.
Otherwise, the error message will be printed redundantly or missing.

Hi tglx and Rafael,

Could you please consider merging the entire series into your branch? 
To be honest, I don't know whether merging into the irq repository or
the pm repository is the right approach.

Pan Chuang (2):
  thermal/drivers/loongson2: convert to use devm_request*_irq_probe()
  thermal/drivers/airoha: convert to use devm_request*_irq_probe()

Yangtao Li (22):
  genirq/devres: Add devm_request_threaded_irq_probe() and
    devm_request_irq_probe()
  thermal/drivers/sun8i: convert to use devm_request*_irq_probe()
  thermal/drivers/armada: convert to use devm_request*_irq_probe()
  thermal/drivers/broadcom: convert to use devm_request*_irq_probe()
  thermal/drivers/tegra: convert to use devm_request*_irq_probe()
  thermal/drivers/qcom/lmh: convert to use devm_request*_irq_probe()
  thermal/drivers/db8500: convert to use devm_request*_irq_probe()
  thermal/drivers/renesas/rcar: convert to use devm_request*_irq_probe()
  thermal/drivers/qcom/temp-alarm: convert to use
    devm_request*_irq_probe()
  thermal: intel: int340x: processor_thermal: convert to use
    devm_request*_irq_probe()
  thermal/drivers/exynos: convert to use devm_request*_irq_probe()
  thermal/drivers/hisi: convert to use devm_request*_irq_probe()
  thermal/drivers/rockchip: convert to use devm_request*_irq_probe()
  thermal/drivers/renesas/rcar_gen3: convert to use
    devm_request*_irq_probe()
  thermal/drivers/mediatek/lvts_thermal: convert to use
    devm_request*_irq_probe()
  thermal/drivers/max77620: convert to use devm_request*_irq_probe()
  thermal/drivers/intel/bxt_pmic: convert to use
    devm_request*_irq_probe()
  thermal/drivers/stm: convert to use devm_request*_irq_probe()
  thermal/drivers/qcom/tsens-v0_1: convert to use
    devm_request*_irq_probe()
  thermal/drivers/qcom/spmi-adc-tm5: convert to use
    devm_request*_irq_probe()
  thermal/drivers/uniphier: convert to use devm_request*_irq_probe()
  thermal/drivers/imx: convert to use devm_request*_irq_probe()

 drivers/thermal/airoha_thermal.c              | 10 ++---
 drivers/thermal/armada_thermal.c              | 13 +++---
 drivers/thermal/broadcom/brcmstb_thermal.c    | 11 +++--
 drivers/thermal/db8500_thermal.c              | 16 +++----
 drivers/thermal/hisi_thermal.c                | 12 +++---
 drivers/thermal/imx_thermal.c                 | 11 +++--
 .../processor_thermal_device_pci.c            | 24 +++++------
 .../thermal/intel/intel_bxt_pmic_thermal.c    | 11 ++---
 drivers/thermal/loongson2_thermal.c           |  8 ++--
 drivers/thermal/max77620_thermal.c            | 24 +++++------
 drivers/thermal/mediatek/lvts_thermal.c       |  6 +--
 drivers/thermal/qcom/lmh.c                    |  7 ++-
 drivers/thermal/qcom/qcom-spmi-adc-tm5.c      |  5 ++-
 drivers/thermal/qcom/qcom-spmi-temp-alarm.c   |  4 +-
 drivers/thermal/qcom/tsens.c                  | 23 +++++-----
 drivers/thermal/renesas/rcar_gen3_thermal.c   |  7 +--
 drivers/thermal/renesas/rcar_thermal.c        |  9 ++--
 drivers/thermal/rockchip_thermal.c            | 12 +++---
 drivers/thermal/samsung/exynos_tmu.c          | 12 +++---
 drivers/thermal/st/st_thermal_memmap.c        | 12 +++---
 drivers/thermal/st/stm_thermal.c              | 14 +++---
 drivers/thermal/sun8i_thermal.c               |  6 +--
 drivers/thermal/tegra/soctherm.c              | 38 ++++++++--------
 drivers/thermal/tegra/tegra30-tsensor.c       |  9 ++--
 drivers/thermal/uniphier_thermal.c            |  6 +--
 include/linux/interrupt.h                     | 15 +++++++
 kernel/irq/devres.c                           | 43 +++++++++++++++++++
 27 files changed, 197 insertions(+), 171 deletions(-)

-- 
2.39.0

Powered by blists - more mailing lists