linux-kernel - Re: [PATCH v5] coccinelle: misc: Add field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e694666a-ec94-4443-bae7-54ac2f0f0e7d@web.de>
Date: Tue, 24 Jun 2025 15:54:15 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Luo Jie <quic_luoj@...cinc.com>, cocci@...ia.fr,
 Catalin Marinas <catalin.marinas@....com>, Joey Gouly <joey.gouly@....com>,
 Julia Lawall <Julia.Lawall@...ia.fr>, Marc Zyngier <maz@...nel.org>,
 Nicolas Palix <nicolas.palix@...g.fr>, Oliver Upton
 <oliver.upton@...ux.dev>, Rasmus Villemoes <linux@...musvillemoes.dk>,
 Suzuki Poulose <suzuki.poulose@....com>, Will Deacon <will@...nel.org>,
 Yury Norov <yury.norov@...il.com>, Zenghui Yu <yuzenghui@...wei.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 kvmarm@...ts.linux.dev, Andrew Lunn <andrew@...n.ch>,
 "Kiran Kumar C.S.K" <quic_kkumarcs@...cinc.com>,
 Lei Wei <quic_leiwei@...cinc.com>, Pavithra R <quic_pavir@...cinc.com>,
 Suruchi Agarwal <quic_suruchia@...cinc.com>, quic_linchen@...cinc.com
Subject: Re: [PATCH v5] coccinelle: misc: Add field_modify script

> +msg="WARNING: Consider using FIELD_MODIFY helper on %s" % (x)
> +msg_safe=msg.replace("[","@(").replace("]",")")
> +coccilib.org.print_todo(p[0], msg_safe)

How do you think about to use the following code variant instead?

msg = f"WARNING: Consider using FIELD_MODIFY helper on {x}"
coccilib.org.print_todo(p[0], msg.replace("[","@(").replace("]",")"))


Regards,
Markus