linux-kernel - Re: [PATCH ath-next v3 5/6] wifi: ath11k: choose default PM policy for hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b77ff7e-13c9-4083-9273-b8d3050e5116@quicinc.com>
Date: Tue, 24 Jun 2025 10:11:29 +0800
From: Baochen Qiang <quic_bqiang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Johannes Berg
	<johannes@...solutions.net>,
        Jeff Johnson <jjohnson@...nel.org>
CC: <linux-wireless@...r.kernel.org>, <ath11k@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>,
        Bjorn Andersson
	<bjorn.andersson@....qualcomm.com>,
        Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH ath-next v3 5/6] wifi: ath11k: choose default PM policy
 for hibernation



On 6/23/2025 7:30 PM, Konrad Dybcio wrote:
> On 6/18/25 4:00 AM, Baochen Qiang wrote:
>>
>> On 6/18/2025 8:15 AM, Konrad Dybcio wrote:
>>> On 3/28/25 6:32 AM, Baochen Qiang wrote:
>>>> Now WoWLAN mode is chosen for those machines listed in the quirk table.
>>>> This works for suspend (S3) but breaks for hibernation (S4), because
>>>> WoWLAN mode requires WLAN power to be sustained, which is not the case
>>>> during hibernation. For hibernation, the default mode should be used.
>>>>
>>>> Register a PM notifier with which kernel can notify us of the actual PM
>>>> operation: if system is going to suspend, the original PM policy is
>>>> honored; while if it is hibernation, overwrite it with default policy.
>>>>
>>>> To summarize: for suspend (S3), WoWLAN mode is chosen for machines listed
>>>> in the quirk table, non-WoWLAN mode for others; for hibernation (S4),
>>>> non-WoWLAN mode is chosen for all.
>>>>
>>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>>>>
>>>> Tested-by: Takashi Iwai <tiwai@...e.de>
>>>> Signed-off-by: Baochen Qiang <quic_bqiang@...cinc.com>
>>>> ---
> [...]
> 
>> Could you share complete kernel dmesg log?
> There's nothing interesting in it, but sure..
> 
> [    0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd4b0]
> [    0.000000] Linux version 6.16.0-rc3-next-20250623 (konrad@...hlinux) (clang version 20.1.6, LLD 20.1.6) #12182 SMP Mon Jun 23 13:27:07 CEST 2025
> [    0.000000] KASLR enabled
> [    0.000000] Machine model: Qualcomm SC8280XP CRD

[...]

> [    7.669494] mhi mhi0: Direct firmware load for ath11k/WCN6855/hw2.0/amss.bin failed
with error -2

Thanks, this helps understand the issue.

And BTW, WLAN firmware is missing in your setup, you may get them from linux firmware repo
to avoid this issue.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git