linux-kernel - RE: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f0636a92de94d608276a1f6da17e4d7@huawei.com>
Date: Tue, 24 Jun 2025 14:49:08 +0000
From: Shiju Jose <shiju.jose@...wei.com>
To: Li Ming <ming.li@...omail.com>, "dave@...olabs.net" <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>, "dave.jiang@...el.com"
	<dave.jiang@...el.com>, "alison.schofield@...el.com"
	<alison.schofield@...el.com>, "vishal.l.verma@...el.com"
	<vishal.l.verma@...el.com>, "ira.weiny@...el.com" <ira.weiny@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>
CC: "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram
 event record

>-----Original Message-----
>From: Li Ming <ming.li@...omail.com>
>Sent: 20 June 2025 06:29
>To: dave@...olabs.net; Jonathan Cameron <jonathan.cameron@...wei.com>;
>dave.jiang@...el.com; alison.schofield@...el.com; vishal.l.verma@...el.com;
>ira.weiny@...el.com; dan.j.williams@...el.com; Shiju Jose
><shiju.jose@...wei.com>
>Cc: linux-cxl@...r.kernel.org; linux-kernel@...r.kernel.org; Li Ming
><ming.li@...omail.com>
>Subject: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event
>record
>
>cxl_find_rec_dram() is used to find a DRAM event record based on the inputted
>attributes. Different repair_type of the inputted attributes will check the DRAM
>event record in different ways.
>When EDAC driver is performing a memory rank sparing, it should use
>CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
>event record checking.
>
>Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing
>control feature")
>Signed-off-by: Li Ming <ming.li@...omail.com>
>---
>base-commit: 3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 cxl/fixes

Reviewed-by: Shiju Jose <shiju.jose@...wei.com>
>---
> drivers/cxl/core/edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c index
>d725ee954199..623aaa4439c4 100644
>--- a/drivers/cxl/core/edac.c
>+++ b/drivers/cxl/core/edac.c
>@@ -1323,7 +1323,7 @@ cxl_mem_get_rec_dram(struct cxl_memdev *cxlmd,
> 		attrbs.bank = ctx->bank;
> 	break;
> 	case EDAC_REPAIR_RANK_SPARING:
>-		attrbs.repair_type = CXL_BANK_SPARING;
>+		attrbs.repair_type = CXL_RANK_SPARING;
> 		break;
> 	default:
> 		return NULL;
>--
>2.34.1