linux-kernel - Re: [PATCH linux next] tools/accounting/delaytop: add delaytop to record top-n task delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250624101835869AZSKLr2_kXapp5khYIQ7H@zte.com.cn>
Date: Tue, 24 Jun 2025 10:18:35 +0800 (CST)
From: <yang.yang29@....com.cn>
To: <wang.yaxin@....com.cn>, <fan.yu9@....com.cn>
Cc: <bsingharora@...il.com>, <akpm@...ux-foundation.org>, <david@...hat.com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-doc@...r.kernel.org>, <wang.yong12@....com.cn>,
        <he.peilin@....com.cn>, <tu.qiang35@....com.cn>,
        <qiu.yutan@....com.cn>, <zhang.yunkai@....com.cn>,
        <ye.xingchen@....com.cn>, <xu.xin16@....com.cn>,
        <jiang.kun2@....com.cn>
Subject: Re: [PATCH linux next] tools/accounting/delaytop: add delaytop
 to record top-n task delay

> For latency-sensitive scenarios, such as industrial control, communications,
> or automotive, I think this tool is useful. And it may be better if it support
> showing whole delay of system by reading PSI, just like the first few lines of
> information output by the top command.

Another suggestion, we can provide a new command to control the display of
either the total memory delay for tasks or detailed memory delays. This approach
offers two benefits: first, it better aligns with PSI results; second, it offers choices
for users with different interests (e.g., some users may not have enabled or are
not concerned about swap delay). The implementation can follow the dynamic
command approach similar to top.

If it's OK to you, may send follow-up patch. For the initial patch:
> + * delaytop.c - task delay monitoring tool.
> + * This tool provides real-time monitoring and statistics of
> + * system, container, and task-level delays, including CPU,
Since the tool cover 'system' delay, we may say:
delaytop.c - system-wide delay monitoring tool.

> + * This tool provides real-time monitoring and statistics of
> + * system, container, and task-level delays, including CPU,
> + * memory, IO, and IRQ and delay accounting. It supports both
I am confused with the words 'and delay accouting', they are all
delays.

> +	if (bind(fd, (struct sockaddr *) &local, sizeof(local)) < 0) {
> +		close(fd); 
> +		return -1;
We better tell user what happend, and pelase check other code
that may also fail.

> +	rc = recv(nl_sd, &resp, sizeof(resp), 0);
Please check if close(nl_sd) is called.