linux-kernel - RE: [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <910133af3684449cab0dba7a9389df04@realtek.com>
Date: Tue, 24 Jun 2025 02:28:46 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Pei Xiao <xiaopei01@...inos.cn>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags

Pei Xiao <xiaopei01@...inos.cn> wrote:
> This silences the following coccinelle warning:
>   WARNING: sum of probable bitmasks, consider |
> 
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
>  drivers/net/wireless/realtek/rtw88/coex.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
> index 64904278ddad..37788aca200b 100644
> --- a/drivers/net/wireless/realtek/rtw88/coex.c
> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
> @@ -1500,23 +1500,23 @@ static u8 rtw_coex_algorithm(struct rtw_dev *rtwdev)
>         case BPM_HFP:
>                 algorithm = COEX_ALGO_HFP;
>                 break;
> -       case           BPM_HID:
> -       case BPM_HFP + BPM_HID:
> +       case BPM_HID:
> +       case BPM_HFP | BPM_HID:
>                 algorithm = COEX_ALGO_HID;
>                 break;
> -       case BPM_HFP           + BPM_A2DP:
> -       case           BPM_HID + BPM_A2DP:
> -       case BPM_HFP + BPM_HID + BPM_A2DP:
> +       case BPM_HFP | BPM_A2DP:
> +       case BPM_HID | BPM_A2DP:
> +       case BPM_HFP | BPM_HID | BPM_A2DP:
>                 algorithm = COEX_ALGO_A2DP_HID;
>                 break;
> -       case BPM_HFP                      + BPM_PAN:
> -       case           BPM_HID            + BPM_PAN:
> -       case BPM_HFP + BPM_HID            + BPM_PAN:
> +       case BPM_HFP | BPM_PAN:
> +       case BPM_HID | BPM_PAN:
> +       case BPM_HFP | BPM_HID | BPM_PAN:

Please just replace '+' by '|'. Keep spaces. People can be easier to see the
combination of BT profiles.

>                 algorithm = COEX_ALGO_PAN_HID;
>                 break;
> -       case BPM_HFP           + BPM_A2DP + BPM_PAN:
> -       case           BPM_HID + BPM_A2DP + BPM_PAN:
> -       case BPM_HFP + BPM_HID + BPM_A2DP + BPM_PAN:
> +       case BPM_HFP | BPM_A2DP | BPM_PAN:
> +       case BPM_HID | BPM_A2DP | BPM_PAN:
> +       case BPM_HFP | BPM_HID | BPM_A2DP | BPM_PAN:
>                 algorithm = COEX_ALGO_A2DP_PAN_HID;
>                 break;
>         case                                BPM_PAN:
> --
> 2.25.1