linux-kernel - Re: [PATCH -next] security: Remove unused declaration cap_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhQ50UM6LxnUT7PSrGKNdbuUFJmZQmir1HtrQg_C9j6x2Q@mail.gmail.com>
Date: Tue, 24 Jun 2025 11:48:10 -0400
From: Paul Moore <paul@...l-moore.com>
To: sergeh@...nel.org
Cc: Yue Haibing <yuehaibing@...wei.com>, jmorris@...ei.org, serge@...lyn.com, 
	casey@...aufler-ca.com, linux-security-module@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] security: Remove unused declaration cap_mmap_file()

On Tue, Jun 24, 2025 at 8:27 AM <sergeh@...nel.org> wrote:
> On Tue, Jun 24, 2025 at 09:41:08AM +0800, Yue Haibing wrote:
> > Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
> > removed the implementation but leave declaration.
> >
> > Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
>
> Hm, how did I not catch that?  Thanks.

At least you weren't the idiot who wrote the original patch ;)

I'll grab this for the LSM tree in a bit unless you want to take it.

> Reviewed-by: Serge Hallyn <serge@...lyn.com>
>
> > ---
> >  include/linux/security.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/security.h b/include/linux/security.h
> > index dba349629229..e8d9f6069f0c 100644
> > --- a/include/linux/security.h
> > +++ b/include/linux/security.h
> > @@ -193,8 +193,6 @@ int cap_inode_getsecurity(struct mnt_idmap *idmap,
> >                         struct inode *inode, const char *name, void **buffer,
> >                         bool alloc);
> >  extern int cap_mmap_addr(unsigned long addr);
> > -extern int cap_mmap_file(struct file *file, unsigned long reqprot,
> > -                      unsigned long prot, unsigned long flags);
> >  extern int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags);
> >  extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
> >                         unsigned long arg4, unsigned long arg5);
> > --
> > 2.34.1

-- 
paul-moore.com