linux-kernel - Re: [PATCH] lib/crypto: x86/sha512: Remove unnecessary checks for nblocks==0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250624024539.GB7127@sol>
Date: Mon, 23 Jun 2025 19:45:39 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, "Jason A . Donenfeld " <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>, x86@...nel.org
Subject: Re: [PATCH] lib/crypto: x86/sha512: Remove unnecessary checks for
 nblocks==0

On Fri, Jun 20, 2025 at 07:15:49PM -0700, Eric Biggers wrote:
> Since sha512_blocks() is called only with nblocks >= 1, remove
> unnecessary checks for nblocks == 0 from the x86 SHA-512 assembly code.
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  lib/crypto/x86/sha512-avx-asm.S   | 6 +-----
>  lib/crypto/x86/sha512-avx2-asm.S  | 5 +----
>  lib/crypto/x86/sha512-ssse3-asm.S | 6 +-----
>  3 files changed, 3 insertions(+), 14 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

- Eric