linux-kernel - Re: [PATCH v5 1/3] vfio/type1: batch vfio_find_vpfn() in function vfio_unpin_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506250037.VfdBAPP3-lkp@intel.com>
Date: Wed, 25 Jun 2025 00:23:03 +0800
From: kernel test robot <lkp@...el.com>
To: lizhe.67@...edance.com, alex.williamson@...hat.com, jgg@...pe.ca,
	david@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, peterx@...hat.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, lizhe.67@...edance.com
Subject: Re: [PATCH v5 1/3] vfio/type1: batch vfio_find_vpfn() in function
 vfio_unpin_pages_remote()

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on awilliam-vfio/for-linus linus/master v6.16-rc3 next-20250624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/lizhe-67-bytedance-com/vfio-type1-batch-vfio_find_vpfn-in-function-vfio_unpin_pages_remote/20250620-112605
base:   https://github.com/awilliam/linux-vfio.git next
patch link:    https://lore.kernel.org/r/20250620032344.13382-2-lizhe.67%40bytedance.com
patch subject: [PATCH v5 1/3] vfio/type1: batch vfio_find_vpfn() in function vfio_unpin_pages_remote()
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250625/202506250037.VfdBAPP3-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506250037.VfdBAPP3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506250037.VfdBAPP3-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/vfio/vfio_iommu_type1.c: In function 'vfio_unpin_pages_remote':
>> drivers/vfio/vfio_iommu_type1.c:738:37: error: implicit declaration of function 'vpfn_pages'; did you mean 'vma_pages'? [-Werror=implicit-function-declaration]
     738 |         long unlocked = 0, locked = vpfn_pages(dma, iova, npage);
         |                                     ^~~~~~~~~~
         |                                     vma_pages
   cc1: some warnings being treated as errors


vim +738 drivers/vfio/vfio_iommu_type1.c

   733	
   734	static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova,
   735					    unsigned long pfn, unsigned long npage,
   736					    bool do_accounting)
   737	{
 > 738		long unlocked = 0, locked = vpfn_pages(dma, iova, npage);
   739		long i;
   740	
   741		for (i = 0; i < npage; i++)
   742			if (put_pfn(pfn++, dma->prot))
   743				unlocked++;
   744	
   745		if (do_accounting)
   746			vfio_lock_acct(dma, locked - unlocked, true);
   747	
   748		return unlocked;
   749	}
   750	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki