linux-kernel - Re: [PATCH][next] drm/vmwgfx: fix missing assignment to ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b83e41e-7bb3-4e20-b568-12feaf73a79c@suswa.mountain>
Date: Tue, 24 Jun 2025 19:35:17 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ian Forbes <ian.forbes@...adcom.com>
Cc: Colin Ian King <colin.i.king@...il.com>,
	Zack Rusin <zack.rusin@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/vmwgfx: fix missing assignment to ts

On Tue, Jun 24, 2025 at 10:02:41AM -0500, Ian Forbes wrote:
> On Mon, Jun 23, 2025 at 5:35 PM Colin Ian King <colin.i.king@...il.com> wrote:
> >
> > The assignment to ts is missing on the call to ktime_to_timespec64.
> > Fix this by adding the missing assignment.
> >
> > Fixes: db6a94b26354 ("drm/vmwgfx: Implement dma_fence_ops properly")
> > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> Was this caught by a compiler warning? I'm surprised I didn't get some
> sort of warning for this.
> 

We've disabled uninitialized variable warnings in GCC.  Perhaps
Clang would have caught this but I'm not sure because tracking
uninitialized struct members is a bit more complicated than tracking
uninitialized variables.

regards,
dan carpenter