linux-kernel - RE: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <CY5PR20MB4867E63E4B5107728904826EC678A@CY5PR20MB4867.namprd20.prod.outlook.com>
Date: Tue, 24 Jun 2025 16:57:10 +0000
From: Adam Xue <zxue@...tech.com>
To: Manivannan Sadhasivam <mani@...nel.org>, Thomas Perrot
	<thomas.perrot@...tlin.com>, Aleksander Morgado <aleksander@...ksander.es>
CC: "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"slark_xiao@....com" <slark_xiao@....com>, "johan+linaro@...nel.org"
	<johan+linaro@...nel.org>, "quic_vpernami@...cinc.com"
	<quic_vpernami@...cinc.com>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"fabio.porcedda@...il.com" <fabio.porcedda@...il.com>,
	"quic_msarkar@...cinc.com" <quic_msarkar@...cinc.com>, "mhi@...ts.linux.dev"
	<mhi@...ts.linux.dev>, "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Iulian Mocanu <imocanu@...tech.com>
Subject: RE: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x
 and set MRU to 32768 for better performance.

Hi Mani and Aleksander, 

I may collect the logs if required. Or we can ship an EM91 module for you to validate?

Thanks, 

Adam

-----Original Message-----
From: Manivannan Sadhasivam <mani@...nel.org> 
Sent: June 17, 2025 2:27 AM
To: Adam Xue <zxue@...tech.com>; Thomas Perrot <thomas.perrot@...tlin.com>; Aleksander Morgado <aleksander@...ksander.es>
Cc: manivannan.sadhasivam@...aro.org; slark_xiao@....com; johan+linaro@...nel.org; quic_vpernami@...cinc.com; tglx@...utronix.de; fabio.porcedda@...il.com; quic_msarkar@...cinc.com; mhi@...ts.linux.dev; linux-arm-msm@...r.kernel.org; linux-kernel@...r.kernel.org; Iulian Mocanu <imocanu@...tech.com>
Subject: Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.

Caution: This email originated outside of Semtech.


On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:

+ Thomas and Aleksander (for EM919X related question)

> Add MHI controller config for EM929x. It uses the same configuration 
> as EM919x. Also set the MRU to 32768 to improve downlink throughput.
>

This also affects the EM919X modem. So I want either Thomas or Aleksander to confirm that it doesn't cause any regression.

Rest looks good to me.

- Mani

> 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
>       Subsystem: Device 18d7:0301
>
> Signed-off-by: Adam Xue <zxue@...tech.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c 
> b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..9bf8e7991745 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
>       .config = &modem_sierra_em919x_config,
>       .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>       .dma_data_width = 32,
> +     .mru_default = 32768,
>       .sideband_wake = false,
>  };
>
> @@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>       /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
>       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
>               .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> },
> +     /* EM929x (sdx65), use the same configuration as EM919x */
> +     { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
> +             .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> + },
>       /* Telit FN980 hardware revision v1 */
>       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
>               .driver_data = (kernel_ulong_t) 
> &mhi_telit_fn980_hw_v1_info },
> --
> 2.45.2
>
>
> To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

--
மணிவண்ணன் சதாசிவம்

To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.