linux-kernel - Re: [PATCH v4] staging: media: atomisp: fix coding style in ia_css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeijMvnbrCmRuqTeo_maxevCA9rB-r5URHaX+TrDNvyGA@mail.gmail.com>
Date: Tue, 24 Jun 2025 21:12:31 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: andy@...nel.org, hansg@...nel.org, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v4] staging: media: atomisp: fix coding style in ia_css_output.host.c

On Tue, Jun 24, 2025 at 6:20 PM LiangCheng Wang <zaq14760@...il.com> wrote:

> You're right — the driver is quite large and contains many similar issues.
> To keep the patches manageable and easier to review, I plan to split the cleanup into multiple smaller patches.
> I'll start by submitting a series of patches, each focusing on a specific file or type of issue.

Please don't base on file, base only on type of issue. But cover
entire driver. And if you do some work with a script (shell,
coccinelle or similar), include the text in the comment or cover
letter so the maintainer may do the similar steps on their side and
check if the result is the same or so.

> Since I’m contributing in my free time outside of work, I may need to spread the cleanup over several days.
> I’ll do my best to keep the patches consistent and focused.

No problem, take your time and thanks for your help!

-- 
With Best Regards,
Andy Shevchenko