linux-kernel - Re: [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dbd4c98-f161-4f91-aacd-08ab2b7f155c@ursu.me>
Date: Tue, 24 Jun 2025 21:54:15 +0300
From: Vlad URSU <vlad@...u.me>
To: Jacek Kowalski <jacek@...ekk.info>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] e1000e: ignore factory-default checksum value on
 TGP platform

On 24.06.2025 21:34, Jacek Kowalski wrote:

> You are right that I'm comparing the wrong value. But it is only a 
> matter of variable name:

Ah, yes, you're right. I missed the fact that nvm_data will hold the 
checksum word at the end of the for loop.

> -    if (hw->mac.type == e1000_pch_tgp && checksum ==
> (u16)NVM_SUM_FACTORY_DEFAULT) {
> +    if (hw->mac.type == e1000_pch_tgp && nvm_data ==
> (u16)NVM_SUM_FACTORY_DEFAULT) {
> 
> Could you check my change with this modification?

It works with this change.