linux-kernel - Re: [PATCH] ASoC: SOF: Intel: hda: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175079234144.274448.17790781183539385240.b4-ty@kernel.org>
Date: Tue, 24 Jun 2025 20:12:21 +0100
From: Mark Brown <broonie@...nel.org>
To: Liam Girdwood <lgirdwood@...il.com>, 
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>, 
 Bard Liao <yung-chuan.liao@...ux.intel.com>, 
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>, 
 Daniel Baluta <daniel.baluta@....com>, 
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>, 
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>, 
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
 Tamura Dai <kirinode0@...il.com>
Cc: sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SOF: Intel: hda: Use devm_kstrdup() to avoid
 memleak.

On Mon, 16 Jun 2025 08:55:48 +0900, Tamura Dai wrote:
> sof_pdata->tplg_filename can have address allocated by kstrdup()
> and can be overwritten. Memory leak was detected with kmemleak:
> 
> unreferenced object 0xffff88812391ff60 (size 16):
>   comm "kworker/4:1", pid 161, jiffies 4294802931
>   hex dump (first 16 bytes):
>     73 6f 66 2d 68 64 61 2d 67 65 6e 65 72 69 63 00  sof-hda-generic.
>   backtrace (crc 4bf1675c):
>     __kmalloc_node_track_caller_noprof+0x49c/0x6b0
>     kstrdup+0x46/0xc0
>     hda_machine_select.cold+0x1de/0x12cf [snd_sof_intel_hda_generic]
>     sof_init_environment+0x16f/0xb50 [snd_sof]
>     sof_probe_continue+0x45/0x7c0 [snd_sof]
>     sof_probe_work+0x1e/0x40 [snd_sof]
>     process_one_work+0x894/0x14b0
>     worker_thread+0x5e5/0xfb0
>     kthread+0x39d/0x760
>     ret_from_fork+0x31/0x70
>     ret_from_fork_asm+0x1a/0x30
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: Intel: hda: Use devm_kstrdup() to avoid memleak.
      commit: 6c038b58a2dc5a008c7e7a1297f5aaa4deaaaa7e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark