linux-kernel - Re: [PATCH][next] pinctrl: eswin: Fix unsigned comparison to less than zero issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb1voqurnhj7TX8h1GPDO9ER_3JyZkDusJ8hz45YzYzHQ@mail.gmail.com>
Date: Tue, 24 Jun 2025 21:38:13 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Yulin Lu <luyulin@...incomputing.com>, Samuel Holland <samuel.holland@...ive.com>, 
	linux-gpio@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] pinctrl: eswin: Fix unsigned comparison to less
 than zero issue

On Tue, Jun 24, 2025 at 12:20 AM Colin Ian King <colin.i.king@...il.com> wrote:

> The u32 variable voltage is being compared to less than zero and
> this can never be true. Fix this by making voltage an int type which
> is the same type as the return from the call to regulator_get_voltage.
>
> Fixes: 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Patch applied!

Yours,
Linus Walleij