linux-kernel - [PATCH 0/2] Fix soc-button-array debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250624202211.1088738-1-superm1@kernel.org>
Date: Tue, 24 Jun 2025 15:22:09 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Hans de Goede <hansg@...nel.org>,
	Mika Westerberg <westeri@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-gpio@...r.kernel.org (open list:GPIO ACPI SUPPORT),
	linux-acpi@...r.kernel.org (open list:GPIO ACPI SUPPORT),
	linux-kernel@...r.kernel.org (open list),
	linux-input@...r.kernel.org (open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...),
	Mario Limonciello <mario.limonciello@....com>
Subject: [PATCH 0/2] Fix soc-button-array debounce

From: Mario Limonciello <mario.limonciello@....com>

I have some hardware in front of me that uses the soc-button-array
driver but the power button doesn't work.

Digging into it, it's because the ASL prescribes a debounce of 0 for
the power button, but the soc-button-array driver hardcodes 50ms.

Hardcoding it to what the ASL expects the power button works.

I looked at the callpath into the GPIO core and I believe it's
because the debounce value from _CRS is never programmed to the
hardware the way that the GPIO gets setup.

This series add that programming path and then drops the hardcoded
value.  Hopefully Hans can confirm this continues to work on the
hardware that he originally developed the hardcoding for.

If it doesn't work on that hardware, I think it's more scalable
to introduce a quirk for it so that the kernel can at least set
the values intended by the firmware.

Mario Limonciello (2):
  gpiolib: acpi: Program debounce when finding GPIO
  Revert "Input: soc_button_array - debounce the buttons"

 drivers/gpio/gpiolib-acpi-core.c      | 4 ++++
 drivers/input/misc/soc_button_array.c | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.43.0