linux-kernel - Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFsU3YjzjxzR2drQ@lizhi-Precision-Tower-5810>
Date: Tue, 24 Jun 2025 17:13:01 -0400
From: Frank Li <Frank.li@....com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Jorge Marques <jorge.marques@...log.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Przemysław Gaj <pgaj@...ence.com>,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and
 i3c_writel_fifo()

On Tue, Jun 24, 2025 at 10:30:42PM +0200, Wolfram Sang wrote:
> On Tue, Jun 24, 2025 at 02:08:45PM -0400, Frank Li wrote:
> > On Tue, Jun 24, 2025 at 11:06:04AM +0200, Jorge Marques wrote:
> > > The I3C abstraction expects u8 buffers, but some controllers operate with
> > > a 32-bit bus width FIFO and cannot flag valid bytes individually. To avoid
> > > reading or writing outside the buffer bounds, use 32-bit accesses where
> > > possible and apply memcpy for any remaining bytes
> > >
> > > Signed-off-by: Jorge Marques <jorge.marques@...log.com>
> >
> > Reviewed-by: Frank Li <Frank.Li@....com>
> >
> > > ---
> > >  drivers/i3c/internals.h | 37 +++++++++++++++++++++++++++++++++++++
>
> Is there a reason we don't put this in 'include/linux/i3c/master.h'?

master.h can be accessed in whole kernel tree. The scope is too big for these
helper functions, which should only limited to i3c drivers.

> 'internals.h' is used for the core only so far, and '#include
> <../something.h>' also looks a bit like a layering violation.

Not yet, you can look driver/pci/controller/*,  which include ../pci.h.

Frank
>