linux-kernel - Re: [PATCH 2/2] KVM: SVM: Simplify MSR interception logic for IA32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFsrWYaF9Ces3lIl@google.com>
Date: Tue, 24 Jun 2025 15:48:57 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Chao Gao <chao.gao@...el.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org, pbonzini@...hat.com, 
	dapeng1.mi@...ux.intel.com
Subject: Re: [PATCH 2/2] KVM: SVM: Simplify MSR interception logic for
 IA32_XSS MSR

On Thu, Jun 12, 2025, Chao Gao wrote:
> Use svm_set_intercept_for_msr() directly to configure IA32_XSS MSR
> interception, ensuring consistency with other cases where MSRs are
> intercepted depending on guest caps and CPUIDs.
> 
> No functional change intended.
> 
> Signed-off-by: Chao Gao <chao.gao@...el.com>
> ---
> With this patch applied, svm_enable_intercept_for_msr() has no user.
> Should it be removed?

I'd say leave it.  If it's a static inline, then there's no dead overhead in the
binary, and I like having parity between VMX and SVM.