linux-kernel - Re: [PATCH v3 0/2] bpf: Specify access type of bpf_sysctl_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175074120875.3399614.10605130442249512213.git-patchwork-notify@kernel.org>
Date: Tue, 24 Jun 2025 05:00:08 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jerome Marchand <jmarchan@...hat.com>
Cc: bpf@...r.kernel.org, martin.lau@...ux.dev, ast@...nel.org,
 daniel@...earbox.net, andrii@...nel.org, yonghong.song@...ux.dev,
 eddyz87@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] bpf: Specify access type of bpf_sysctl_get_name
 args

Hello:

This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Thu, 19 Jun 2025 16:06:01 +0200 you wrote:
> The second argument of bpf_sysctl_get_name() helper is a pointer to a
> buffer that is being written to. However that isn't specify in the
> prototype. Until commit 37cce22dbd51a ("bpf: verifier: Refactor helper
> access type tracking") that mistake was hidden by the way the verifier
> treated helper accesses. Since then, the verifier, working on wrong
> infromation from the prototype, can make faulty optimization that
> would had been caught by the test_sysctl selftests if it was run by
> the CI.
> 
> [...]

Here is the summary with links:
  - [v3,1/2] bpf: Specify access type of bpf_sysctl_get_name args
    https://git.kernel.org/bpf/bpf/c/2eb7648558a7
  - [v3,2/2] selftests/bpf: Convert test_sysctl to prog_tests
    https://git.kernel.org/bpf/bpf/c/b8a205486ed5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html