linux-kernel - [PATCH] pinctrl: actions: use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250624062220.21997-1-hanqi@vivo.com>
Date: Tue, 24 Jun 2025 14:22:20 +0800
From: Qi Han <hanqi@...o.com>
To: linus.walleij@...aro.org,
	afaerber@...e.de,
	mani@...nel.org
Cc: linux-gpio@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-actions@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Qi Han <hanqi@...o.com>
Subject: [PATCH] pinctrl: actions: use devm_clk_get_enabled()

Use devm_clk_get_enabled() to simplify the code.

Change-Id: I0902c50e50db565381c65e8d8a7f1481e82b271a
Signed-off-by: Qi Han <hanqi@...o.com>
---
 drivers/pinctrl/actions/pinctrl-owl.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index 86f3d5c69e36..a66739a27489 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -941,18 +941,13 @@ int owl_pinctrl_probe(struct platform_device *pdev,
 		return PTR_ERR(pctrl->base);
 
 	/* enable GPIO/MFP clock */
-	pctrl->clk = devm_clk_get(&pdev->dev, NULL);
+	pctrl->clk = devm_clk_get_enabled(&pdev->dev, NULL);
+
 	if (IS_ERR(pctrl->clk)) {
 		dev_err(&pdev->dev, "no clock defined\n");
 		return PTR_ERR(pctrl->clk);
 	}
 
-	ret = clk_prepare_enable(pctrl->clk);
-	if (ret) {
-		dev_err(&pdev->dev, "clk enable failed\n");
-		return ret;
-	}
-
 	raw_spin_lock_init(&pctrl->lock);
 
 	owl_pinctrl_desc.name = dev_name(&pdev->dev);
@@ -1006,7 +1001,5 @@ int owl_pinctrl_probe(struct platform_device *pdev,
 	return 0;
 
 err_exit:
-	clk_disable_unprepare(pctrl->clk);
-
 	return ret;
 }
-- 
2.48.1