linux-kernel - RE: [PATCH 02/10] mei: vsc: Don't re-init VSC from mei_vsc_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6370F9796B6ADF1B765D05A9ED78A@IA1PR11MB6370.namprd11.prod.outlook.com>
Date: Tue, 24 Jun 2025 07:00:54 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Hans de Goede <hansg@...nel.org>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>, Stanislaw Gruszka
	<stanislaw.gruszka@...ux.intel.com>
CC: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 02/10] mei: vsc: Don't re-init VSC from mei_vsc_hw_reset()
 on stop

> Subject: [PATCH 02/10] mei: vsc: Don't re-init VSC from mei_vsc_hw_reset()
> on stop
> 
> mei_vsc_hw_reset() gets called from mei_start() and mei_stop() in
> the latter case we do not need to re-init the VSC by calling vsc_tp_init().
> 
> mei_stop() only happens on shutdown and driver unbind. On shutdown we
> don't need to load + boot the firmware and if the driver later is
> bound to the device again then mei_start() will do another reset.
> 
> The intr_enable flag is true when called from mei_start() and false on
> mei_stop(). Skip vsc_tp_init() when intr_enable is false.
> 
> This avoids unnecessarily uploading the firmware, which takes 11 seconds.
> This change reduces the poweroff/reboot time by 11 seconds.
> 

Reviewed-by:  Alexander Usyskin <alexander.usyskin@...el.com>

> Fixes: 386a766c4169 ("mei: Add MEI hardware support for IVSC device")
> Signed-off-by: Hans de Goede <hansg@...nel.org>
> ---
>  drivers/misc/mei/platform-vsc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vsc.c
> index 435760b1e86f..1ac85f0251c5 100644
> --- a/drivers/misc/mei/platform-vsc.c
> +++ b/drivers/misc/mei/platform-vsc.c
> @@ -256,6 +256,9 @@ static int mei_vsc_hw_reset(struct mei_device
> *mei_dev, bool intr_enable)
> 
>  	vsc_tp_reset(hw->tp);
> 
> +	if (!intr_enable)
> +		return 0;
> +
>  	return vsc_tp_init(hw->tp, mei_dev->dev);
>  }
> 
> --
> 2.49.0