linux-kernel - Re: [PATCH 2/9] iio: adc: ad_sigma_delta: use u8 instead of uint8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFpRz9GtlEYn_UoF@smile.fi.intel.com>
Date: Tue, 24 Jun 2025 10:20:47 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH 2/9] iio: adc: ad_sigma_delta: use u8 instead of uint8_t

On Mon, Jun 23, 2025 at 03:48:30PM -0600, David Lechner wrote:
> On Mon, Jun 23, 2025 at 12:51 AM Andy Shevchenko
> <andriy.shevchenko@...el.com> wrote:
> > On Fri, Jun 20, 2025 at 05:20:08PM -0500, David Lechner wrote:
> > > Replace uint8_t with u8 in the ad_sigma_delta driver.

...

> > >       unsigned int reset_length = sigma_delta->info->num_resetclks;
> > > -     uint8_t *buf;
> > > +     u8 *buf;
> > >       unsigned int size;
> > >       int ret;
> >
> > Wondering if in the cases like this we may make it to be reversed xmas tree.
> 
> Fine with me as long as Jonathan doesn't mind the noise since it looks
> like I will be doing a v2 anyway.

I mean the cases when you touch already the variables and this won't be any
*additional* churn to what the change has.

> >         unsigned int reset_length = sigma_delta->info->num_resetclks;
> >         unsigned int size;
> >         u8 *buf;
> >         int ret;

-- 
With Best Regards,
Andy Shevchenko