linux-kernel - Re: 回覆: [PATCH 0/7] Add ASPEED PCIe Root Complex support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <754d260c-1a31-494e-af06-49f6aae1813f@linaro.org>
Date: Tue, 24 Jun 2025 09:29:11 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Jacky Chou <jacky_chou@...eedtech.com>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
 "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
 "mani@...nel.org" <mani@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>, "joel@....id.au"
 <joel@....id.au>, "andrew@...econstruct.com.au"
 <andrew@...econstruct.com.au>, "vkoul@...nel.org" <vkoul@...nel.org>,
 "kishon@...nel.org" <kishon@...nel.org>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
 "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Cc: "elbadrym@...gle.com" <elbadrym@...gle.com>,
 "romlem@...gle.com" <romlem@...gle.com>,
 "anhphan@...gle.com" <anhphan@...gle.com>, "wak@...gle.com"
 <wak@...gle.com>, "yuxiaozhang@...gle.com" <yuxiaozhang@...gle.com>,
 BMC-SW <BMC-SW@...eedtech.com>
Subject: Re: 回覆: [PATCH 0/7] Add ASPEED PCIe Root Complex support

On 20/06/2025 10:20, Jacky Chou wrote:
>>> This series has been tested on AST2600/AST2700 platforms and enables
>>> PCIe device enumeration and operation.
>>>
>>> Feedback and review are welcome.
>>
>> So it seems all PCIe RC code is bundled in a single driver and there's no PCIe
>> PHY driver code, is there a reason for that ? If yes I think it should be described
>> in the cover letter.
>>
> 
> Yes, because our design includes the PCIe RC and the PCIe EPs.
> The two functions use the same PCIe PHY and are mutually exclusive.
> And there are different configurations on RC and EP.
> Therefore, we do not use a phy driver to configure our PCIe but use
> the phandle of phy syscon to set the RC and EP drivers separately.

I don't get why a PHY drive could not exist, it could be used by either
the RC or EP PCIe driver in an exclusive way.

Neil

> 
> I will add more description in next version.
> 
> Thanks,
> Jacky
>