linux-kernel - Re: [PATCH 2/2] dt-bindings: trivial-devices: Add mp2869a/mp29612a device entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4f45fbd-2929-491c-8f5e-413b9c481259@kernel.org>
Date: Tue, 24 Jun 2025 09:44:35 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: tzuhao.wtmh@...il.com, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>, Jonathan Corbet <corbet@....net>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Naresh Solanki <naresh.solanki@...ements.com>,
 Fabio Estevam <festevam@...il.com>, Michal Simek <michal.simek@....com>,
 Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, Henry Wu <Henry_Wu@...ntatw.com>,
 Grant Peltier <grantpeltier93@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Cedric Encarnacion <cedricjustine.encarnacion@...log.com>,
 John Erasmus Mari Geronimo <johnerasmusmari.geronimo@...log.com>,
 Noah Wang <noahwang.wang@...look.com>, Ninad Palsule <ninad@...ux.ibm.com>,
 Jerome Brunet <jbrunet@...libre.com>, Leo Yang <leo.yang.sy0@...il.com>,
 Mariel Tinaco <Mariel.Tinaco@...log.com>, Alex Vdovydchenko
 <xzeol@...oo.com>, Kim Seer Paller <kimseer.paller@...log.com>,
 Nuno Sa <nuno.sa@...log.com>, Thomas Weißschuh
 <linux@...ssschuh.net>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add mp2869a/mp29612a
 device entry

On 24/06/2025 09:41, tzuhao.wtmh@...il.com wrote:
> From: Henry Wu <Henry_Wu@...ntatw.com>
> 
> Add trivial-devices binding for mp2869a/mp29612a to enable automatic matching
> in device tree.

Drop "enable automatic ...." - this is not what is being done here.
Instead describe the hardware.

Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

> 
> Signed-off-by: Henry Wu <Henry_Wu@...ntatw.com>


> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 27930708ccd5..e9a3a6f2c59e 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -287,8 +287,12 @@ properties:
>            - mps,mp2857
>              # Monolithic Power Systems Inc. multi-phase controller mp2888
>            - mps,mp2888
> +            # Monolithic Power Systems Inc. multi-phase controller mp2869a
> +          - mps,mp2869a

69 < 88


Best regards,
Krzysztof