linux-kernel - Re: [PATCH] ALSA: qc_audio_offload: Fix missing error code in prepare_qmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sejplftp.wl-tiwai@suse.de>
Date: Tue, 24 Jun 2025 10:11:14 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Wesley Cheng <quic_wcheng@...cinc.com>,
	Mark Brown <broonie@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	error27@...il.com
Subject: Re: [PATCH] ALSA: qc_audio_offload: Fix missing error code in prepare_qmi_response()

On Mon, 23 Jun 2025 16:26:27 +0200,
Harshit Mogalapalli wrote:
> 
> When snd_soc_usb_find_priv_data() fails, return failure instead of
> success. While we are at it also use direct returns at first few error
> paths where there is no additional cleanup needed.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/Z_40qL4JnyjR4j0O@stanley.mountain/
> Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>

Thanks, applied now.


Takashi