linux-kernel - Re: [PATCH] mei: vsc: Remove unused irq functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30565c88-fb3c-4970-a7c8-bb81200a13aa@redhat.com>
Date: Tue, 24 Jun 2025 10:40:47 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: linux@...blig.org, alexander.usyskin@...el.com
Cc: arnd@...db.de, gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: vsc: Remove unused irq functions

Hi David,

On 17-Jun-25 2:34 AM, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> vsc_tp_request_irq() and vsc_tp_free_irq() last uses were removed in 2024
> by
> commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during system
> suspend/resume")
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Alexander pointed me at this patch because I just posted
almost the same patch:

https://lore.kernel.org/lkml/20250623085052.12347-2-hansg@kernel.org/

Normally I would say lets go with your (David's) version since
you posted your patch first.

But your patch is missing the removal of the function prototypes
from vsc-tp.h, so in this case I think we should go with my version.

Regards,

Hans



> ---
>  drivers/misc/mei/vsc-tp.c | 31 -------------------------------
>  1 file changed, 31 deletions(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> index 267d0de5fade..99a55451e1fc 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -406,37 +406,6 @@ int vsc_tp_register_event_cb(struct vsc_tp *tp, vsc_tp_event_cb_t event_cb,
>  }
>  EXPORT_SYMBOL_NS_GPL(vsc_tp_register_event_cb, "VSC_TP");
>  
> -/**
> - * vsc_tp_request_irq - request irq for vsc_tp device
> - * @tp: vsc_tp device handle
> - */
> -int vsc_tp_request_irq(struct vsc_tp *tp)
> -{
> -	struct spi_device *spi = tp->spi;
> -	struct device *dev = &spi->dev;
> -	int ret;
> -
> -	irq_set_status_flags(spi->irq, IRQ_DISABLE_UNLAZY);
> -	ret = request_threaded_irq(spi->irq, vsc_tp_isr, vsc_tp_thread_isr,
> -				   IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> -				   dev_name(dev), tp);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> -}
> -EXPORT_SYMBOL_NS_GPL(vsc_tp_request_irq, "VSC_TP");
> -
> -/**
> - * vsc_tp_free_irq - free irq for vsc_tp device
> - * @tp: vsc_tp device handle
> - */
> -void vsc_tp_free_irq(struct vsc_tp *tp)
> -{
> -	free_irq(tp->spi->irq, tp);
> -}
> -EXPORT_SYMBOL_NS_GPL(vsc_tp_free_irq, "VSC_TP");
> -
>  /**
>   * vsc_tp_intr_synchronize - synchronize vsc_tp interrupt
>   * @tp: vsc_tp device handle